Support imposeProfile extension in validation#611
Merged
alexzautke merged 4 commits intodevelopfrom Nov 5, 2025
Merged
Conversation
…rceSchema Co-authored-by: alexzautke <548617+alexzautke@users.noreply.github.com>
Co-authored-by: alexzautke <548617+alexzautke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for ImposeProfile in validation
Support imposeProfile extension in validation
Oct 31, 2025
alexzautke
requested changes
Oct 31, 2025
alexzautke
requested changes
Oct 31, 2025
test/Firely.Fhir.Validation.Compilation.Tests.Shared/ImposeProfileTests.cs
Show resolved
Hide resolved
alexzautke
requested changes
Oct 31, 2025
test/Firely.Fhir.Validation.Compilation.Tests.Shared/ImposeProfileTests.cs
Show resolved
Hide resolved
Member
|
@copilot Take a look at the requested changes |
…e validation test Co-authored-by: alexzautke <548617+alexzautke@users.noreply.github.com>
Member
|
@Kasdejong @andrzejskowronski This looks like a promising start, maybe you can check this out? |
Kasdejong
approved these changes
Nov 5, 2025
Member
Kasdejong
left a comment
There was a problem hiding this comment.
this looks very good indeed. And it works? Well... that proves we did in fact write the validator in a pluggable way :))
alexzautke
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support ImposeProfile extension in validation
Changes made based on PR feedback:
SchemaBuilder.cs: Simplified
getImposeProfiles()to only handleFhirUritype since the extension must always containvalueCanonical(represented asFhirUriin the SDK)ImposeProfileTests.cs:
Canonicaltype in R4+ (with conditional compilation for STU3)ValidationAgainstProfileWithImposeProfile_ValidatesImposedConstraintsthat:All source projects build successfully across STU3, R4, R4B, and R5.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.