Made sure we do not overwrite data when correcting type references#610
Merged
ewoutkramer merged 1 commit intodevelopfrom Oct 30, 2025
Merged
Conversation
… data on the TypeRefComponent
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the correctIdElement method to simplify the logic for correcting ID element type references in FHIR structure definitions. The change replaces a multi-step validation and replacement pattern with a more concise pattern matching approach.
- Replaced explicit count checks and element recreation with pattern matching and direct property modification
- Changed from creating a new Type collection to modifying the existing TypeRefComponent's Code property in-place
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Firely.Fhir.Validation.Compilation.Shared/StructureDefinitionCorrectionsResolver.cs
Show resolved
Hide resolved
Member
|
@Kasdejong Did you find an answer to the http://hl7.org/fhir/StructureDefinition/structuredefinition-fhir-type question in the ticket? |
ewoutkramer
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified the structureDefCorrectionsResolver to no longer overwrite profile references and other information from the typeRefComponent when correcting the type code.
Related issues
closes #583