Add big validation bundle, enable cross version benchmarking#580
Merged
ewoutkramer merged 1 commit intodevelop-sdk6from Sep 18, 2025
Merged
Add big validation bundle, enable cross version benchmarking#580ewoutkramer merged 1 commit intodevelop-sdk6from
ewoutkramer merged 1 commit intodevelop-sdk6from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive cross-version benchmarking system for the FHIR validation SDK and replaces a smaller test resource with a large validation bundle to enable performance comparisons between SDK versions 2.7.0 and 2.8.0-alpha.
- Simplified validator benchmarks and added cross-version configuration for comparing SDK versions
- Created a large JSON test bundle with 80+ FHIR resources for more substantial performance testing
- Added infrastructure for conditional compilation based on SDK version constants
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ValidatorBenchmarks.cs | Streamlined benchmark class with cross-version attributes and conditional compilation for different SDK versions |
| ValidationBundle.json | New large test bundle containing 80+ diverse FHIR resources for performance testing |
| IsExternalInit.cs | Compatibility shim for C# 9.0 init setters on older target frameworks |
| CrossVersionConfiguration.cs | Custom BenchmarkDotNet configuration for cross-version package testing |
| Benchmarks.csproj | Updated project file with conditional package references and simplified content includes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ewoutkramer
approved these changes
Sep 18, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From benchmarking the SDK5 version and SDK6 version of validator, I saw around 5-10% improvement in run-time, but more importantly 20% reduction in memory usage.
Related issues
Closes #505