Skip to content

feat: implement validators rpc#78

Merged
egonspace merged 2 commits intofeature/voteset_work1from
feature/voteset_work3
May 28, 2020
Merged

feat: implement validators rpc#78
egonspace merged 2 commits intofeature/voteset_work1from
feature/voteset_work3

Conversation

@egonspace
Copy link
Contributor

@egonspace egonspace commented May 15, 2020

Closes: #33

Description

By #74, we should use the rpc voters instead of validators.
But it would be more convenient for the client to know both the validators and the voters, so I implemented the rpc validators.

And in #74, lite2's rpc validators has not been modified so I added voters rpc to lite2.

== How to use ==

<start server>
$ tendermint node --proxy_app=kvstore

<start lite client>
$ tendermint lite test-chain-M40t5Z -p "http://127.0.0.1:26657" --height 1 --hash 89032E166DB8B9D50FC7178BF1C44FF756D6EBCA07C20296B6986096140FEA60 -w "http://127.0.0.1:26657"

<rpc test>
// to lite client
curl -s "localhost:8888/validators"
curl -s "localhost:8888/voters"

// to server
curl -s "localhost:26657/validators"
curl -s "localhost:26657/voters"


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@egonspace egonspace self-assigned this May 15, 2020
@egonspace egonspace added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label May 15, 2020
@egonspace egonspace linked an issue May 15, 2020 that may be closed by this pull request
Copy link
Contributor

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 6cf5e7a into feature/voteset_work1 May 28, 2020
@egonspace egonspace deleted the feature/voteset_work3 branch June 22, 2020 08:45
@zemyblue zemyblue mentioned this pull request Jun 22, 2020
@zemyblue zemyblue mentioned this pull request Jul 3, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: enhancement Classification: New feature or its request, or improvement in maintainability of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Election of ValidatorSet based on VRF

3 participants