Skip to content

Upgrade to Golang-1.18#450

Merged
tnasu merged 5 commits intoFinschia:mainfrom
tnasu:main-1.18
Aug 4, 2022
Merged

Upgrade to Golang-1.18#450
tnasu merged 5 commits intoFinschia:mainfrom
tnasu:main-1.18

Conversation

@tnasu
Copy link
Member

@tnasu tnasu commented Aug 3, 2022

Description

Upgrade to Golang-1.18 since the current version of Golang-1.15 is so old and already out of support.

And super linter suddenly failed. I modified to the default behaviour of super linter.

* Upgrade golang-1.16

* Upgrade golang-1.17

* Upgrade golang-1.18
@kokehiM0chi kokehiM0chi added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #450 (5202f36) into main (2231684) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   65.46%   65.51%   +0.04%     
==========================================
  Files         278      278              
  Lines       37920    37920              
==========================================
+ Hits        24824    24842      +18     
+ Misses      11286    11265      -21     
- Partials     1810     1813       +3     
Impacted Files Coverage Δ
consensus/reactor.go 74.84% <0.00%> (-0.71%) ⬇️
consensus/state.go 73.32% <0.00%> (-0.24%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
p2p/conn/connection.go 80.00% <0.00%> (+0.19%) ⬆️
p2p/switch.go 66.52% <0.00%> (+0.61%) ⬆️
types/tx.go 93.90% <0.00%> (+3.65%) ⬆️
blockchain/v0/pool.go 83.72% <0.00%> (+5.94%) ⬆️

@tnasu tnasu marked this pull request as ready for review August 3, 2022 08:39
@tnasu tnasu requested review from kokehiM0chi and torao as code owners August 3, 2022 08:39
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit 97cd427 into Finschia:main Aug 4, 2022
@tnasu tnasu deleted the main-1.18 branch August 16, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: enhancement Classification: New feature or its request, or improvement in maintainability of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants