Integrate libsodium (Algorand's VRF lib) into Tendermint by torao · Pull Request #4 · Finschia/ostracon

torao · 2019-11-28T05:20:46Z

This PR on #1, #2 allows us to call the library libsodium implemented in C from within the Tendermint project. This contains golang functions that are equivalent to the VRF functions defined in libsodium.

Note that the libsodium used in this PR is a cryptography library of the same name with VRF capability (IRFT Draft 3) added by Algorand. The original libsodium does not contain a VRF.

In a newly checked out environment, libsodium must be built and installed before compiling golang.

$ cd crypto/vrf/internal/vrf/libsodium
$ ./autogen.sh
$ ./configure
$ make && make check
$ sudo make install

torao · 2019-12-11T07:13:42Z

local unit-test passed

tnasu

LGTM

egonspace · 2019-12-13T05:46:56Z

crypto/vrf/internal/vrf/vrf.go

+    messagePtr := (*C.uchar)(unsafe.Pointer(&message))
+    messageLen := (C.ulonglong)(len(message))
+    if C.crypto_vrf_prove(proofPtr, privateKeyPtr, messagePtr, messageLen) != 0 {
+        return nil, errors.New(fmt.Sprintf("unable to decode the given privateKey: %s",


If some error can be raised with correct privateKey and wrong message, printing private key in log is not good for security reasons.

Exactly, I'll fix it.

egonspace · 2019-12-13T06:02:22Z

crypto/vrf/vrf_test.go

+    if err3 != nil {
+        t.Errorf("failed to verify: %s", err3)
+    } else if ! bytes.Equal(hash1[:], hash2[:]) {
+        t.Errorf("output incompativle: %s != %s", enc(hash1[:]), enc(hash2[:]))


typo: incompativle
and I am asking for just wonder, is the result of verifying same to proof?

fix it.
Yes, the outputs of proof_to_hash() and verify() must exactly match for a valid proof pi. According to the IETF draft 4:

Thus, the VRF also comes with an algorithm

VRF_verify(PK, alpha, pi)

that outputs (VALID, beta = VRF_proof_to_hash(pi)) if pi is valid, and INVALID otherwise."

egonspace · 2019-12-13T06:08:41Z

crypto/vrf/internal/vrf/vrf.go

+    privateKeyPtr := (*C.uchar)(unsafe.Pointer(privateKey))
+    C.crypto_vrf_sk_to_seed(seedPtr, privateKeyPtr) // void
+    return &seed
+}


I understand that VRF has four functions(hash(), prove(), proofToHash(), verify()). But I cannot see hash() function in this file. Must the prover use proofToHash() rather than hash() to get beta?

Yes, it is. This PR is to integrate the libsodium API and the library doesn't provide a hash() function. I think this is because hash() can be composited from prove() and hash_to_poof(). This probably follows the IETF policy.

Notice that this means that

VRF_hash(SK, alpha) = VRF_proof_to_hash(VRF_prove(SK, alpha))

and thus this document will specify VRF_prove and VRF_proof_to_hash
rather than VRF_hash.

…int into feature/integrate_libsodium

zemyblue · 2020-01-08T11:25:58Z

CircleCI normalize 🎉

Changes

Add pulling submodules.
Add the function that compile libsodium
Change the libsodium library path to /include and /lib of ./crypto/vrf/internal/vrf/
Comments out coverage report. (temporary prohibit for distinguishing with origin tendermint. I'll ready other solution later.)

tnasu · 2020-01-09T03:06:05Z

BTW, where are our commits? I think this PR is difficult to understand our changes... I'm afraid to squash 224 commits...

zemyblue · 2020-01-09T04:50:52Z

BTW, where are our commits? I think this PR is difficult to understand our changes... I'm afraid to squash 224 commits...

How about merge #11 first?
And then if merge from latest master branch, the origin changes will be disappeared.

zemyblue · 2020-01-09T05:34:40Z

Now, we can see only our changes. 😀
Thanks all.

torao · 2020-01-09T09:36:26Z

This PR became complicated by a number of commits and rebases, so we move to a new one #12.

tnasu · 2020-01-09T10:35:05Z

wow, you can rebase using git command and force push on this PR...

torao self-assigned this Nov 28, 2019

torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 28, 2019

torao added this to the Evolve Leader Election into VRF milestone Nov 28, 2019

kfangw force-pushed the feature/integrate_libsodium branch from 056b347 to 885b885 Compare November 28, 2019 05:46

tnasu mentioned this pull request Dec 5, 2019

Implement VRF+BFT Consensus Algorithm #5

Closed

20 tasks

port Algorand's libsodium as VRF APIs

10bcded

torao force-pushed the feature/integrate_libsodium branch from faaf139 to 10bcded Compare December 10, 2019 10:22

torao requested a review from LINK-Network-Dev December 11, 2019 07:14

torao mentioned this pull request Dec 12, 2019

Modify the next Proposer to be selected based on VRF #3

Closed

4 tasks

tnasu approved these changes Dec 12, 2019

View reviewed changes

egonspace self-requested a review December 13, 2019 01:10

egonspace reviewed Dec 13, 2019

View reviewed changes

torao mentioned this pull request Dec 13, 2019

Add functions to generate VRF Proof to PrivValidator-derived classes #6

Closed

tnasu requested a review from zemyblue December 13, 2019 08:29

torao added 3 commits December 24, 2019 17:17

port Algorand's libsodium as VRF APIs

122646c

Merge branch 'feature/integrate_libsodium' of github.com:line/tenderm…

0295e0f

…int into feature/integrate_libsodium

fixed private key log output in case of error

1fecb81

torao force-pushed the feature/integrate_libsodium branch from 100ef8e to 1fecb81 Compare January 6, 2020 10:51

zemyblue added 4 commits January 8, 2020 17:24

Fix circleCI error

f6e7728

Fix circleCI error(2)

c539829

Fix circleCI error(3)

f009ced

Fix circleCI error(4)

c63f848

zemyblue mentioned this pull request Jan 8, 2020

Setup custom CI #10

Closed

2 tasks

egonspace approved these changes Jan 9, 2020

View reviewed changes

Merge branch 'upstream/master' into feature/integrate_libsodium

5bf7df9

torao added 2 commits January 9, 2020 14:53

fixed private key log output in case of error

e0251d4

merge

b985b7b

torao mentioned this pull request Jan 9, 2020

Import libsodium (Algorand's VRF lib) into Tendermint #12

Merged

torao closed this Jan 9, 2020

torao mentioned this pull request Jan 21, 2020

Add function to generate VRF proof to PrivValidators #15

Merged

torao deleted the feature/integrate_libsodium branch June 22, 2020 10:20

This was referenced Mar 8, 2021

merge linemint for initial ebony #197

Closed

merge linemint for initial ebony #198

Merged

Conversation

torao commented Nov 28, 2019

Uh oh!

torao commented Dec 11, 2019

Uh oh!

tnasu left a comment

Choose a reason for hiding this comment

Uh oh!

egonspace Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

torao Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

egonspace Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

torao Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

egonspace Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

torao Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

zemyblue commented Jan 8, 2020

Uh oh!

tnasu commented Jan 9, 2020

Uh oh!

zemyblue commented Jan 9, 2020

Uh oh!

zemyblue commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

torao commented Jan 9, 2020

Uh oh!

tnasu commented Jan 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

torao Jan 6, 2020 •

edited

Loading

zemyblue commented Jan 9, 2020 •

edited

Loading