Skip to content

Modify omission of change to change ValidatorSet to VoterSet#340

Merged
kokehiM0chi merged 1 commit intoFinschia:mainfrom
kokehiM0chi:main
Nov 4, 2021
Merged

Modify omission of change to change ValidatorSet to VoterSet#340
kokehiM0chi merged 1 commit intoFinschia:mainfrom
kokehiM0chi:main

Conversation

@kokehiM0chi
Copy link
Contributor

@kokehiM0chi kokehiM0chi commented Nov 4, 2021

Description

  • Corresponding to the omission of change from the validator set to the voter set during version upgrade work.
    This commit change was not reflected.
    25fe25c

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kokehiM0chi kokehiM0chi self-assigned this Nov 4, 2021
@kokehiM0chi kokehiM0chi changed the title fix: Fix omission of change to change ValidatorSet to VoterSet fix: Modify omission of change to change ValidatorSet to VoterSet Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #340 (a58a3cf) into main (c4d40bc) will increase coverage by 0.17%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   62.82%   62.99%   +0.17%     
==========================================
  Files         272      272              
  Lines       30214    30259      +45     
==========================================
+ Hits        18982    19063      +81     
+ Misses       9504     9465      -39     
- Partials     1728     1731       +3
Impacted Files Coverage Δ
crypto/bls/bls.go 48.41% <0.00%> (ø)
crypto/sr25519/privkey.go 49.05% <ø> (ø)
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
libs/log/testing_logger.go 0.00% <ø> (ø)
types/block.go 75.56% <50.00%> (-0.17%) ⬇️
crypto/encoding/codec.go 61.53% <66.66%> (+1.01%) ⬆️
abci/example/kvstore/persistent_kvstore.go 49.41% <73.68%> (+7.28%) ⬆️
crypto/composite/composite.go 86.66% <81.81%> (+0.95%) ⬆️
abci/example/kvstore/helpers.go 100.00% <100.00%> (ø)
consensus/state.go 70.43% <100.00%> (-0.25%) ⬇️
... and 20 more

@kokehiM0chi kokehiM0chi requested review from tnasu and torao November 4, 2021 07:54
torao
torao approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kokehiM0chi kokehiM0chi added the C: bug Classification: Something isn't working label Nov 4, 2021
@kokehiM0chi kokehiM0chi added the P: emergency Priority: Emergency issue label Nov 4, 2021
@kokehiM0chi kokehiM0chi changed the title fix: Modify omission of change to change ValidatorSet to VoterSet Modify omission of change to change ValidatorSet to VoterSet Nov 4, 2021
@kokehiM0chi kokehiM0chi merged commit b628591 into Finschia:main Nov 4, 2021
This was referenced Nov 17, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnasu tnasu tnasu approved these changes

+1 more reviewer

@torao torao torao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kokehiM0chi kokehiM0chi

Labels

C: bug Classification: Something isn't working P: emergency Priority: Emergency issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kokehiM0chi @CLAassistant @torao @tnasu