Skip to content

feat: add metric for measuring performance#229

Merged
egonspace merged 12 commits intoebonyfrom
egon/ebony/duration_metrics
May 6, 2021
Merged

feat: add metric for measuring performance#229
egonspace merged 12 commits intoebonyfrom
egon/ebony/duration_metrics

Conversation

@egonspace
Copy link
Contributor

@egonspace egonspace commented May 6, 2021 •
edited
Loading

Closes: #XXX

Description

I modified this PR(#126) to make it more practical to use without cherry-pick.

  • used Histogram instead of Gauge to make cumulative numerical calculations easier
  • duration steps are divided as following
    • proposal
    • prevote
    • precommit
    • commit executing: deliverTx
    • commit committing: app commit
    • commit rechecking: rechecking txs of mempool
    • waiting for next new round

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@egonspace egonspace self-assigned this May 6, 2021
@egonspace egonspace added this to the initial ebony milestone May 6, 2021
@egonspace egonspace requested review from iproudhon, kukugi and wetcod May 6, 2021 01:39
wetcod
wetcod approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit fcf6e59 into ebony May 6, 2021
@egonspace egonspace mentioned this pull request May 17, 2021
Merged
@tnasu tnasu deleted the egon/ebony/duration_metrics branch July 7, 2021 05:17
@egonspace egonspace mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kukugi kukugi Awaiting requested review from kukugi

@iproudhon iproudhon Awaiting requested review from iproudhon

1 more reviewer

@wetcod wetcod wetcod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@egonspace egonspace

Labels

None yet

Projects

None yet

Milestone

initial ebony

Development

Successfully merging this pull request may close these issues.

3 participants

@egonspace @wetcod @zemyblue