Conversation
2f05b51 to
9112b3f
Compare
jinsan-line
reviewed
Mar 12, 2021
| "github.com/tendermint/tendermint/libs/service" | ||
| tmsync "github.com/tendermint/tendermint/libs/sync" | ||
| "github.com/line/ostracon/abci/types" | ||
| tmnet "github.com/line/ostracon/libs/net" |
Contributor
Author
There was a problem hiding this comment.
I think it is okay to leave the part that does not affect lbm-sdk. It's a code that's gonna be thrown away anyway.
jinsan-line
reviewed
Mar 12, 2021
jinsan-line
reviewed
Mar 12, 2021
| - uses: actions/checkout@master | ||
| - name: check-breakage | ||
| run: make proto-check-breaking-ci | ||
| # proto-breakage: |
There was a problem hiding this comment.
I think it's better to leave a TODO comment at here. Because I think we'll need proto-breakage finally even though I agree we need to comment it out at this moment.
jinsan-line
reviewed
Mar 12, 2021
abci/client/client.go
Outdated
| // will invoke the callback twice and create a potential race condition. | ||
| // | ||
| // ref: https://github.com/tendermint/tendermint/issues/5439 | ||
| // ref: https://github.com/line/ostracon/issues/5439 |
There was a problem hiding this comment.
I think it might be a subtle topic. Should we revise github issue links as well?
Contributor
Author
There was a problem hiding this comment.
I searched this and modified it, but there must have been something missing. I'll fix it.
jinsan-line
approved these changes
Mar 15, 2021
wetcod
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
github.com/line/ostraconostracontendermintmodule referencing togo.mod: iavl referstendermintFor contributor use:
docs/) and code commentsFiles changedin the Github PR explorer