Skip to content

add public-key type in sending ValidatorUpdate Tx#116

Merged
shiki-tak merged 1 commit intodevelopfrom
fix/missing_publickey_type
Aug 20, 2020
Merged

add public-key type in sending ValidatorUpdate Tx#116
shiki-tak merged 1 commit intodevelopfrom
fix/missing_publickey_type

Conversation

@shiki-tak
Copy link
Contributor

#107
As a result of research, ValidatorUpdate Tx was used only in test, sample app.
Only one of the following places uses keytype.

Description


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@shiki-tak shiki-tak requested a review from torao August 18, 2020 02:22
@shiki-tak shiki-tak force-pushed the fix/missing_publickey_type branch from 13b623c to f869e87 Compare August 18, 2020 07:32
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiki-tak shiki-tak merged commit 48cc715 into develop Aug 20, 2020
@shiki-tak shiki-tak self-assigned this Oct 29, 2020
@egonspace egonspace deleted the fix/missing_publickey_type branch December 10, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants