Skip to content

feat: apply async reactor ostracon#209

Merged
brew0722 merged 1 commit intov2/developfrom
brew0722/v2/feat/apply-async-ostracon
May 27, 2021
Merged

feat: apply async reactor ostracon#209
brew0722 merged 1 commit intov2/developfrom
brew0722/v2/feat/apply-async-ostracon

Conversation

@brew0722
Copy link
Copy Markdown
Contributor

@brew0722 brew0722 commented May 27, 2021

Description

related Finschia/ostracon#261

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@brew0722 brew0722 added the A: improvement Changes in existing functionality label May 27, 2021
@brew0722 brew0722 added this to the performance improvement milestone May 27, 2021
@brew0722 brew0722 self-assigned this May 27, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2021

Codecov Report

Merging #209 (fcfb7ef) into v2/develop (0cb8676) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v2/develop     #209   +/-   ##
===========================================
  Coverage       53.48%   53.48%           
===========================================
  Files             652      652           
  Lines           47345    47345           
===========================================
+ Hits            25322    25324    +2     
+ Misses          19168    19167    -1     
+ Partials         2855     2854    -1
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 86.90% <0.00%> (+0.37%) ⬆️

@brew0722 brew0722 merged commit ade0ff1 into v2/develop May 27, 2021
@brew0722 brew0722 deleted the brew0722/v2/feat/apply-async-ostracon branch May 27, 2021 04:54
@0Tech 0Tech mentioned this pull request Dec 22, 2023
Open
96 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whylee259 whylee259 Awaiting requested review from whylee259

@wetcod wetcod Awaiting requested review from wetcod

@iproudhon iproudhon Awaiting requested review from iproudhon

1 more reviewer

@egonspace egonspace egonspace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brew0722 brew0722

Labels

A: improvement Changes in existing functionality

Projects

None yet

Milestone

performance improvement

Development

Successfully merging this pull request may close these issues.

3 participants

@brew0722 @egonspace @zemyblue