Revised the launch file example in README.md documentation #20
Merged
RyodoTanaka merged 1 commit intoField-Robotics-Japan:masterfrom Jul 19, 2022
Merged
Revised the launch file example in README.md documentation #20RyodoTanaka merged 1 commit intoField-Robotics-Japan:masterfrom
RyodoTanaka merged 1 commit intoField-Robotics-Japan:masterfrom
Conversation
…dyne_pointcloud transform node.
Contributor
Author
|
related to #17 |
RyodoTanaka
approved these changes
Jun 30, 2022
Member
RyodoTanaka
left a comment
There was a problem hiding this comment.
I checked the update, and it works.
I will merge it.
Member
|
We should update the CI test with Unity 2020.3.x LTS version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the README.md document file.
Without setting the paremter "frame_id", the node does not publish /velodyne_points topic.
The topic coming from Unity /velodyne_packets contains frame_id: velodyne, but velodyne transform node set frame_id: odom as default. This consistency makes an error of not publishing the velodyne point cloud topic.