Skip to content

feat: support cmd based health check#271

Merged
FedericoPonzi merged 2 commits intoFedericoPonzi:masterfrom
kemingy:health_cmd
Mar 6, 2025
Merged

feat: support cmd based health check#271
FedericoPonzi merged 2 commits intoFedericoPonzi:masterfrom
kemingy:health_cmd

Conversation

@kemingy
Copy link
Copy Markdown
Collaborator

@kemingy kemingy commented Mar 5, 2025

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@kemingy
feat: support cmd based health check
98140d7 
Signed-off-by: Keming <kemingy94@gmail.com>
@FedericoPonzi
Copy link
Copy Markdown
Owner

FedericoPonzi commented Mar 5, 2025

Thanks a lot for the pr!
Can you please update also the sample service: https://github.com/FedericoPonzi/Horust/blob/master/horust/example_services/sample_service.toml
and https://github.com/FedericoPonzi/Horust/tree/master/docs#healthiness-check

FedericoPonzi
FedericoPonzi approved these changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@FedericoPonzi FedericoPonzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks! I've just left a question, but I think it's good to be merged. It would be good to have an integration test to try it out as well.

Comment thread horust/src/horust/healthcheck/checks.rs
@kemingy
Copy link
Copy Markdown
Collaborator Author

kemingy commented Mar 6, 2025

Thanks a lot for the pr! Can you please update also the sample service: https://github.com/FedericoPonzi/Horust/blob/master/horust/example_services/sample_service.toml and https://github.com/FedericoPonzi/Horust/tree/master/docs#healthiness-check

Updated. Please take a look.

@kemingy
update doc for command healthcheck
ddd4e24 
Signed-off-by: Keming <kemingy94@gmail.com>
@FedericoPonzi FedericoPonzi merged commit e3f7ee0 into FedericoPonzi:master Mar 6, 2025
7 checks passed
@kemingy kemingy deleted the health_cmd branch March 6, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FedericoPonzi FedericoPonzi FedericoPonzi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Command based healthchecks

2 participants

@kemingy @FedericoPonzi