feat: push to ghcr#268
Merged
FedericoPonzi merged 3 commits intoFedericoPonzi:masterfrom Feb 27, 2025
Merged
Conversation
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
Owner
|
Thanks for the pr(s)! I wasn't aware of this upcoming change but reading on https://www.theregister.com/2025/02/22/docker_hub_pull_limits/ it looks like it should not affect the push of containers, right? I'm thinking that in order to keep backward compatibility, we could keep pushing to docker registry and additionally push to ghcr in case someone would prefer it. What do you think? |
Collaborator
Author
|
Yes, this will push to both dockerhub and ghcr. So the generated tag will contain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist: