Skip to content

Conversation

@Jueff
Copy link
Contributor

@Jueff Jueff commented Jan 30, 2025

add a test build task to avoid future ESP32 compile problems for projects based on ESP-IDF 3.3 LTS

@zackees
Copy link
Member

zackees commented Jan 30, 2025

This should be one commit, can you please git squash these into one?

@Jueff Jueff force-pushed the AddBuildESP32@3.3-lts branch from 5634f7d to 5844dce Compare January 31, 2025 09:42
@Jueff
Copy link
Contributor Author

Jueff commented Jan 31, 2025

thank you for the tip, I was wondering how combining commits can be done....

@zackees
Copy link
Member

zackees commented Jan 31, 2025

Ah you've never done it before.

Okay, the first time absolutely sucks but once you figure it out and write a script for its solved for ever.

I can go ahead and git squash and look at the diff for you then approve this cl or not.

But I do suggest you learn how to git squash eventually. It's one of those advanced techniques that really makes a statement of professionalism when you do a PR and helps a PR get accepted very quickly. A bunch of commits has a code smell and is a quick indicator that the person is at a lower skill level.

Your PRs are so high quality I just assumed you knew how to do this already.

@zackees zackees merged commit 55991f1 into FastLED:master Feb 1, 2025
46 checks passed
@Jueff Jueff deleted the AddBuildESP32@3.3-lts branch February 1, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants