Skip to content

BUG: Fix the use of Del key to delete Main path nodes#1500

Merged
DSCaskey merged 1 commit intodevelopfrom
fix-main-path-delete
Mar 1, 2026
Merged

BUG: Fix the use of Del key to delete Main path nodes#1500
DSCaskey merged 1 commit intodevelopfrom
fix-main-path-delete

Conversation

@DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Mar 1, 2026

This PR fixes the use of the Del key shortcut when deleting nodes from the main path in the Pattern Piece tool dialog.

Closes issue #1498

@what-the-diff
Copy link

what-the-diff bot commented Mar 1, 2026

PR Summary 📝

  • Smoother Event Processing
    Instead of forcefully ending the process for several key system events with return true;, we are now simply breaking out of the current event with break; statements, thereby ensuring a smoother and more efficient event processing flow. Super awesome! 🚀

  • State Verification and Node List Update
    To wrap it all up, we've placed checks at the end of the same eventFilter function. validateObjects(isMainPathValid()); and nodeListChanged(); functions are running to ensure that the status of our system objects consistently stays accurate, and the entire node list is always up-to-date right after we process each key event. Really neat update to help everything stay in sync! 👍

@DSCaskey DSCaskey linked an issue Mar 1, 2026 that may be closed by this pull request
@DSCaskey DSCaskey force-pushed the fix-main-path-delete branch from 75bcaa8 to 6608d75 Compare March 1, 2026 01:16
@DSCaskey DSCaskey merged commit d7eace3 into develop Mar 1, 2026
12 checks passed
@DSCaskey DSCaskey deleted the fix-main-path-delete branch March 1, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Del key allows user to delete all Pattern Piece path nodes

2 participants