Improve the way of generating Egyptian National Ids#651
Merged
pimjansen merged 5 commits intoFakerPHP:mainfrom May 28, 2023
ahmedghanem00:main
Merged
Improve the way of generating Egyptian National Ids#651pimjansen merged 5 commits intoFakerPHP:mainfrom ahmedghanem00:main
pimjansen merged 5 commits intoFakerPHP:mainfrom
ahmedghanem00:main
Conversation
Author
|
I totally forgot about the unit test file 😅. I've run PHP-cs-fixer on that file as well, and hopefully no tests will fail. |
pimjansen
approved these changes
May 28, 2023
|
Looks good thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
As the old way of generating national-ids wasn't accurate. This change should fix that
Review checklist