Skip to content

Fix: Reject invalid arguments#642

Merged
localheinz merged 1 commit intoFakerPHP:mainfrom
localheinz:fix/reject
May 2, 2023
Merged

Fix: Reject invalid arguments#642
localheinz merged 1 commit intoFakerPHP:mainfrom
localheinz:fix/reject

Conversation

@localheinz
Copy link
Copy Markdown
Member

@localheinz localheinz commented May 1, 2023

What is the reason for this PR?

This pull request

  • rejects invalid arguments passed to randomElement() and randomElements()

Follows #639.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

Copy link
Copy Markdown

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@localheinz localheinz merged commit cd773f4 into FakerPHP:main May 2, 2023
@localheinz
Copy link
Copy Markdown
Member Author

Thank you, @pimjansen!

@localheinz localheinz deleted the fix/reject branch May 2, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants