Removed ${var} usage - deprecated in PHP 8.2#591
Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom Jan 3, 2023
janlanger:patch-1
Merged
Removed ${var} usage - deprecated in PHP 8.2#591pimjansen merged 1 commit intoFakerPHP:mainfrom janlanger:patch-1
pimjansen merged 1 commit intoFakerPHP:mainfrom
janlanger:patch-1
Conversation
pimjansen
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Using
${var}in strings is deprecated in PHP 8.2. This is the only usages I found in the libraryAuthor's checklist
Review checklist