Fix PHP 8.2 warning: Use [static::class, '…'] instead of 'static::… for callbacks#570
Merged
localheinz merged 7 commits intoFakerPHP:mainfrom Dec 13, 2022
Merged
Fix PHP 8.2 warning: Use [static::class, '…'] instead of 'static::… for callbacks#570localheinz merged 7 commits intoFakerPHP:mainfrom
[static::class, '…'] instead of 'static::… for callbacks#570localheinz merged 7 commits intoFakerPHP:mainfrom
Conversation
…(PHP 8.2 warning)
Author
|
I guess the |
Member
GrahamCampbell
previously requested changes
Dec 10, 2022
localheinz
requested changes
Dec 10, 2022
Member
localheinz
left a comment
There was a problem hiding this comment.
Can you also apply this diff?
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 1c521356..37222a4f 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -13,7 +13,7 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
</listeners>
<php>
- <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=404"/>
+ <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0"/>
</php>
<testsuites>
<testsuite name="Faker Test Suite">
localheinz
reviewed
Dec 10, 2022
| } | ||
|
|
||
| private static function replaceWildcard($string, $wildcard = '#', $callback = 'static::randomDigit') | ||
| private static function replaceWildcard($string, $wildcard, $callback) |
Member
There was a problem hiding this comment.
Method is private and always invoked with arguments for all parameters - no need for default values.
Also see #571.
localheinz
approved these changes
Dec 10, 2022
[static::class, '…'] instead of 'static::… for callbacks
Author
|
I guess the changes should be squashed on merge? |
Problems have been resolved
Member
|
Thank you, @GrahamCampbell and @MyIgel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
This implements remaining changes for #479 (Use of "static" in callables is deprecated in PHP 8.2) and is an extension of #528 (Ensure php 8.2 compatibility)
Author's checklist
Summary of changes
Use self::class . '::[…]' instead of 'static::[…]' on callbacks which triggered a PHP 8.2 warning. Implementation analogous to php.watch.
The phpstan "errors" can be ignored as that functionality still works for PHP 7.4 and is thus added to ignoreErrors.
Review checklist