Add image formats to Faker\Provider\Image#473
Merged
pimjansen merged 5 commits intoFakerPHP:mainfrom May 11, 2022
Merged
Conversation
pimjansen
requested changes
May 7, 2022
bram-pkg
reviewed
May 7, 2022
|
Phpcs is failing. Can you review? |
bram-pkg
reviewed
May 8, 2022
bram-pkg
reviewed
May 8, 2022
Author
|
I fixed the above issues, but I am unable to run |
Pipeline is green, will do final review tomorrow so we can merge |
pimjansen
approved these changes
May 11, 2022
|
LGTM |
|
Adding a method in an interface is a BC break. |
Interesting, there is a job in the pipeline that checks for backwards compatibility and it has passed for the current pull request: https://github.com/FakerPHP/Faker/actions/runs/2293913195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
The placeholder.com API allows for a few image formats, whereas
image()andimageUrl()inFaker\Provider\Imagedefaulted topng.Author's checklist
Summary of changes
Added a static array to
Faker\Provider\Imagewhich contains allowable image formats (per Placeholder). Appended$formatargument to bothImage::image()andImage::imageUrl()which defaults to 'png'. Throw an exception inImage::imageUrl()if an invalid format is received. Wrote unit tests for all the image formats andIllegalArgumentException.Review checklist