Fix: rename UserAgent edge to msedge#469
Merged
pimjansen merged 4 commits intoFakerPHP:mainfrom Apr 13, 2022
robbinjanssen:patch-1
Merged
Fix: rename UserAgent edge to msedge#469pimjansen merged 4 commits intoFakerPHP:mainfrom robbinjanssen:patch-1
pimjansen merged 4 commits intoFakerPHP:mainfrom
robbinjanssen:patch-1
Conversation
6 tasks
pimjansen
approved these changes
Apr 12, 2022
|
LGTM |
|
@robbinjanssen see CS issue in build |
Author
|
@pimjansen applied the CS changes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
The useragent is called 'edge', when calling a random userAgent via
userAgent()it tries to calluserAgent->edge()but the function is currently calledmsedge(). This PR renames that staticedgeintomsedge.Author's checklist
Summary of changes
tl;dr - rename
edgetomsedgeReview checklist