fix: typo in french phone number#452
Merged
bram-pkg merged 1 commit intoFakerPHP:mainfrom Feb 11, 2022
Merged
Conversation
bram-pkg
approved these changes
Feb 11, 2022
Member
|
LGTM, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
The goal here is to generate as much as possible valid phone numbers.
The original code was one number too long. French phone numbers contains 10 numbers, starting by 0. But this was not generating always 0 for the first number.
In addition, when it comes to e164, the first 0 number is usually not specified (specifying it seems to be valid, but useless and it's not a usage of french people). The quick fix here is to remove this useless (wrong most part of the time!) number.
Summary of changes
Fix: Removed a number in french e164 format
Review checklist