Skip to content

Fix CZ Person birthNumber docblock return type#437

Merged
pimjansen merged 3 commits intoFakerPHP:mainfrom
krsriq:BUGFIX/cz_person_docblock
Jan 27, 2022
Merged

Fix CZ Person birthNumber docblock return type#437
pimjansen merged 3 commits intoFakerPHP:mainfrom
krsriq:BUGFIX/cz_person_docblock

Conversation

@krsriq
Copy link
Copy Markdown

@krsriq krsriq commented Jan 27, 2022

What is the reason for this PR?

The docblock of cs_CZ\Person::birthNumber() has a non existing return type czech.

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Fixed the docblock return type.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

Copy link
Copy Markdown

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@pimjansen pimjansen merged commit f368870 into FakerPHP:main Jan 27, 2022
@krsriq
Copy link
Copy Markdown
Author

krsriq commented Jan 27, 2022

Thanks!

@krsriq krsriq deleted the BUGFIX/cz_person_docblock branch January 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants