Fix regexify escape backslash in character class#434
Merged
pimjansen merged 3 commits intoFakerPHP:mainfrom Jan 28, 2022
Merged
Fix regexify escape backslash in character class#434pimjansen merged 3 commits intoFakerPHP:mainfrom
pimjansen merged 3 commits intoFakerPHP:mainfrom
Conversation
Author
|
Thanks @pimjansen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
This PR removes single escape backslashes from character classes in
regexify().Author's checklist
Summary of changes
Besides the
regexify()change I've added a test that covers the respective issue (note that without the code changes inregexify()this added test fails).Review checklist