Skip to content

allow deprecation-contracts v3.0#397

Merged
GrahamCampbell merged 1 commit intoFakerPHP:mainfrom
rushlow-development:feature/dep-contracts-3.0
Dec 2, 2021
Merged

allow deprecation-contracts v3.0#397
GrahamCampbell merged 1 commit intoFakerPHP:mainfrom
rushlow-development:feature/dep-contracts-3.0

Conversation

@jrushlow
Copy link
Copy Markdown

@jrushlow jrushlow commented Dec 2, 2021

What is the reason for this PR?

Allow using faker with Symfony 6 projects that utilize symfony/deprecation-contracts ^v3.0.0

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

No code based changes required. Allows symfony/deprecation-contracts v2.2 || v3.0

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@GrahamCampbell
Copy link
Copy Markdown
Member

Hmm, who broke the BC check build?

@jrushlow
Copy link
Copy Markdown
Author

jrushlow commented Dec 2, 2021

The 2 CI failures appear to be unrelated. Looking in PR #396 - the same failures exist.

@GrahamCampbell GrahamCampbell merged commit 05e9bd3 into FakerPHP:main Dec 2, 2021
@GrahamCampbell
Copy link
Copy Markdown
Member

Thanks. :)

@jrushlow jrushlow deleted the feature/dep-contracts-3.0 branch December 2, 2021 22:42
@GrahamCampbell
Copy link
Copy Markdown
Member

This will be included in the v1.17.0 release. I should have some time this weekend to look into getting that out the door.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants