Reset formatters when adding a new provider#386
Merged
bram-pkg merged 1 commit intoFakerPHP:mainfrom Dec 21, 2021
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
|
Anyone reviewing this? |
Member
|
Yes, sorry, this PR got swept under my radar. Could you rebase on main so the BC Roave check doesn't break? |
|
@aanfarhan kindly rebase on main. |
localheinz
reviewed
Dec 21, 2021
8d2b436 to
46ace5f
Compare
…ion called if the current formatter exists in the new added provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Fixed bug #366
This bug occurred when you add new Provider after calling the previous provider formatter with the same function name as the new one. To explain it more clearly read this code:
Author's checklist
Summary of changes
Remove existing formatters that match the new Provider formatters when calling addProvider function.
Review checklist