updates to en_za/internet#383
Merged
pimjansen merged 2 commits intoFakerPHP:mainfrom Oct 17, 2021
mikerockett:patch-1
Merged
Conversation
This adds gTLDs, the commonly used .africa, and increases the likelihood of a .co.za or .com being used.
|
Can we sort them as mention in the contribution guide? |
Author
|
@pimjansen Happy to sort them, however I'm not seeing it mentioned in the contribution guide (am I missing something?), and the original list was not sorted (except that it matched the order of the linked wiki). Update: List is now sorted alphabetically, and doc block is improved. |
pimjansen
approved these changes
Oct 17, 2021
Author
|
Thanks! |
Member
|
This should not have been merged with the BC check failing. The BC check config should have been adjusted to explicitly allow this break. I've adjusted the repo config to block this going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Add data to the ZA Internet provider namespace (TLDs).
Author's checklist
New features and changes are documented(not applicable)Summary of changes
This adds gTLDs, the commonly used .africa, and increases the likelihood of a .co.za or .com being used.
Review checklist