Support Payment Provider for ne_NP#375
Merged
pimjansen merged 16 commits intoFakerPHP:mainfrom Oct 2, 2021
remotemerge:main
Merged
Support Payment Provider for ne_NP#375pimjansen merged 16 commits intoFakerPHP:mainfrom remotemerge:main
pimjansen merged 16 commits intoFakerPHP:mainfrom
remotemerge:main
Conversation
pimjansen
requested changes
Sep 13, 2021
pimjansen
left a comment
There was a problem hiding this comment.
Overall nice addition but needs some small work. Can you also ensure that for all data additions the source is added?
bram-pkg
requested changes
Sep 13, 2021
Add data source link
bram-pkg
requested changes
Sep 14, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Author
|
@bram-pkg @pimjansen, it's time to review :) |
bram-pkg
requested changes
Sep 29, 2021
pimjansen
approved these changes
Oct 2, 2021
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
This PR supports the
Paymentprovider for thene_NPlocale.Author's checklist
Summary of changes
The
Payment.phpandPaymentTest.phpare new files for thene_NPlocale.Review checklist