Update the Generator::getFormatter to support extensions#267
Merged
pimjansen merged 4 commits intoFakerPHP:mainfrom Aug 8, 2021
Merged
Update the Generator::getFormatter to support extensions#267pimjansen merged 4 commits intoFakerPHP:mainfrom
pimjansen merged 4 commits intoFakerPHP:mainfrom
Conversation
Nyholm
commented
Jan 16, 2021
| * @return callable | ||
| */ | ||
| public function getFormatter($formatter) | ||
| public function getFormatter($format) |
Member
Author
There was a problem hiding this comment.
We are using a format to get a formatter.
| return preg_replace_callback('/\{\{\s?(\w+)\s?\}\}/u', [$this, 'callFormatWithMatches'], $string); | ||
| $callback = function ($matches) { | ||
| return $this->format($matches[1]); | ||
| }; |
Member
Author
There was a problem hiding this comment.
This anonymous function is replacing Generator::callFormatWithMatches()
krsriq
reviewed
Jan 16, 2021
localheinz
reviewed
Jan 27, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Co-authored-by: Daniel Schmelz <daniel@schmelz.org>
dc554f0 to
8bcf885
Compare
Member
Author
|
Thank you for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to write:
Which is needed by extensions implementing
GeneratorAwareExtension