Merged
Conversation
Member
|
Can you please change the CI script as well, so that we still build this stuff in our CI builds? (we should still build it there, to make sure it does not break, as long, as we still have it) --- a/FairRoot_build_test.cmake
+++ b/FairRoot_build_test.cmake
@@ -1,5 +1,5 @@
################################################################################
-# Copyright (C) 2021-2022 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH #
+# Copyright (C) 2021-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH #
# #
# This software is distributed under the terms of the #
# GNU Lesser General Public Licence (LGPL) version 3, #
@@ -50,6 +50,9 @@ endif()
if ((NOT DEFINED BUILD_PROOF_SUPPORT) OR BUILD_PROOF_SUPPORT)
list(APPEND options "-DBUILD_PROOF_SUPPORT=ON")
endif()
+if ((NOT DEFINED BUILD_EVENT_BUILDER) OR BUILD_EVENT_BUILDER)
+ list(APPEND options "-DBUILD_EVENT_BUILDER=ON")
+endif()
if (USE_CLANG_TIDY)
list(APPEND options "-DCMAKE_CXX_CLANG_TIDY=clang-tidy")
endif() |
b2b5f28 to
21b0f69
Compare
ChristianTackeGSI
requested changes
Jun 23, 2023
21b0f69 to
6c7bbda
Compare
rbx
reviewed
Jun 29, 2023
| * The affected code in FairRoot is disabled by default now | ||
| * It can still be enabled with `-DBUILD_PROOF_SUPPORT=ON`. | ||
| * Deprecated FairEventBuilder and FairEventBuilderManager | ||
| * The funcionality, introduced to enable event reconstruction, is not used. |
Member
There was a problem hiding this comment.
Suggested change
| * The funcionality, introduced to enable event reconstruction, is not used. | |
| * The functionality, introduced to enable event reconstruction, is not used. |
The classes `FairEventBuilder` and `FairEventBuilderManager`, originally introduced to enable event reconstruction in time-based mode seem not to be used by any experiment. Therefore, implemented `BUILD_EVENT_BUILDER` flag in preparation to disable them.
It can still be enabled with `BUILD_EVENT_BUILDER=ON`
6c7bbda to
96c3b2d
Compare
ChristianTackeGSI
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced
BUILD_EVENT_BUILDERflag, that allowsdisabling build of
FairEventBuilderandFairEventBuilderManagerclasses.Set it to
OFF.Consequence of discussion in PR #1406.
Checklist: