Merged
Conversation
Member
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
First quick looks. I'll take a deeper look tomorrow.
c6dcc91 to
1c5180c
Compare
Member
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Just a bunch of more notes. I have to admit, that I haven't understood all of the stuff here. I might take another round.
ac92ee7 to
8525f92
Compare
ChristianTackeGSI
previously approved these changes
Feb 8, 2023
Member
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
I am okay with this now. Others might take a look as well?
Member
Author
|
Updated the format >.> |
karabowi
approved these changes
Feb 9, 2023
3 tasks
dennisklein
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
basemq/tasks/FairMQ*Taskheader only.Remove unused files:
basemq/baseMQtools/baseMQtools.hbasemq/policies/Sampler/FairMQFileSource.hbasemq/policies/Sampler/FairSourceMQInterface.hbasemq/policies/Sampler/SimpleTreeReader.hbasemq/policies/Serialization/BinaryBaseClassSerializer.hbasemq/policies/Storage/BinaryOutFileManager.hbasemq/policies/Storage/BoostDataSaver.hbasemq/policies/Storage/TriviallyCopyableDataSaver.hThese are not used anywhere in FairRoot nor in Alice, CBM, PANDA or R3B.
Rewrite MBSSink without policies.
basemq/policies/Serialization/IOPolicy.hSimplify RootOutFileManager and move it to the serialization example, where it is used.
In my opinion, these classes add unnecessary indirections, without providing much benefit. The code is much more straight-forward without them. Since they have not been used since their introduction (9 years ago), I don't see a reason to keep maintaining them.
Ideally deprecating them first would be cleaner, but I'm pretty sure they are not in use. Comment if you strongly disagree ;)
This was mainly for me to see if it can be done, and how much it simplifies.
If you think this is a bad idea - comment :)