Skip to content

v18.6_patches: Backport forward compatibility patches for API deprecations in FairLogger and FairMQ#1171

Merged
dennisklein merged 13 commits intoFairRootGroup:v18.6_patchesfrom
dennisklein:v18.6_patches
Apr 13, 2022
Merged

v18.6_patches: Backport forward compatibility patches for API deprecations in FairLogger and FairMQ#1171
dennisklein merged 13 commits intoFairRootGroup:v18.6_patchesfrom
dennisklein:v18.6_patches

Conversation

@dennisklein
Copy link
Copy Markdown
Member

No description provided.

ChristianTackeGSI and others added 13 commits April 12, 2022 23:24
Upper case severities are deprecated in FairLogger 1.10.
So switch all severities over to lower case.
FairRoot depends on a C++11 compiler.
This is fully declared and enforced using CMake native
tooling.

CheckCXX11Features is not used at all any more.

So remove all of its usage in CMakeLists.txt.
Also remove it from the templates.
We do not need it any longer.
And we do not want to provide it to our users.
So remove it completely.
Wraps the `FairMQ::FairMQ` target to support the cleaned namespaced
FairMQ API (FairRootGroup/FairMQ#423).

Also ships transition headers
* "FairMQ.h" and
* "FairRunFairMQDevice.h".

The latter provides a transition from the `<fairmq/runFairMQDevice.h>`
to the `<fairmq/runDevice.h>` header which changed the signature and
return value of the `getDevice` function (see
FairRootGroup/FairMQ@978191f and
FairRootGroup/FairMQ@a7dbead).
Since FairMQ v1.4.0 `FairMQLogger.h` was just a wrapper around
`fairlogger/Logger.h` because all logging features have been factored out to
FairLogger already.
See https://github.com/FairRootGroup/FairMQ/blob/v1.4.0/fairmq/FairMQLogger.h
* see FairRootGroup/FairMQ#423
* uses transition header `"FairMQ.h"` from `FairRoot::FairMQ` target
* minor cleanup of includes and typos
Uses transition header `"FairRunFairMQDevice.h"` from `FairRoot::FairMQ` target.

See FairRootGroup/FairMQ@978191f
When willingly overriding a virtual method, it is good
practice to mark the method with `override`.
Most other places already do so.
Increase the buffers to be large enough for a 32bit
integer. And switch to snprintf.
@dennisklein dennisklein merged commit aace6f0 into FairRootGroup:v18.6_patches Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants