Drop Generate_Exe_Script, and GENERATE_TEST_SCRIPT#1110
Merged
dennisklein merged 4 commits intoFairRootGroup:devfrom Sep 28, 2021
Merged
Drop Generate_Exe_Script, and GENERATE_TEST_SCRIPT#1110dennisklein merged 4 commits intoFairRootGroup:devfrom
Generate_Exe_Script, and GENERATE_TEST_SCRIPT#1110dennisklein merged 4 commits intoFairRootGroup:devfrom
Conversation
dennisklein
requested changes
Sep 24, 2021
Member
dennisklein
left a comment
There was a problem hiding this comment.
Thx, looks good, see one minor inline comment.
Export a variable `FairRoot_BINDIR` containing the full path of `/bin`. Drop `PROJECT_INSTALL_BINDIR`, it was never used.
Install `FairRootConfig.*sh` into CMAKE_INSTALL_BINDIR instead of directly into `bin`. Move `check_system.*` to CMAKE_INSTALL_LIBEXECDIR.
Both are not used inside FairRoot. `Generate_Exe_Script` was never meant for external usage (it expects users to copy a template into a local fixed path). `GENERATE_TEST_SCRIPT` can be replaced by much simpler, and more flexible local code by users.
f487644 to
06af85f
Compare
Member
|
https://cdash.gsi.de/viewTest.php?onlyfailed&buildid=293423 They failed two times in a row (but not on the last build of the dev branch 3 days ago). Can you check, if this is related to this PR? |
cf0442b to
1576b6a
Compare
Member
Author
I have added a commit to catch the segmentation fault. But really, I think, this was not relalted to this change. I will try to look into proper "fixture" setup for these tests. |
dennisklein
requested changes
Sep 28, 2021
1576b6a to
670318c
Compare
dennisklein
previously approved these changes
Sep 28, 2021
Many member functions in `FairParRootFile` do not handle the case of the RootFile member variable being a nullptr. Handle the most important ones.
670318c to
a15789e
Compare
dennisklein
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are not used inside FairRoot.
Generate_Exe_Scriptwas never meant for external usage (it expects users to copy a template into a local fixed path).GENERATE_TEST_SCRIPTcan be replaced by much simpler, and more flexible local code by users.See also: #1109
Checklist:
devbranch