Skip to content

build: Adopt all CMake policies up to 3.30#512

Merged
dennisklein merged 2 commits into
FairRootGroup:devfrom
dennisklein:cmake-330
Aug 20, 2024
Merged

build: Adopt all CMake policies up to 3.30#512
dennisklein merged 2 commits into
FairRootGroup:devfrom
dennisklein:cmake-330

Conversation

@dennisklein

@dennisklein dennisklein commented Aug 19, 2024

Copy link
Copy Markdown
Member

No description provided.

@dennisklein
build: Adopt all CMake policies up to 3.30
9cedd33 
Modernizing to the policy range syntax supported by
[`cmake_minimum_required`](https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html)
since CMake 3.12.
@coderabbitai

coderabbitai Bot commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Walkthrough

Walkthrough

The recent updates include modifications to both the CMake configuration and the Jenkins pipeline. The CMakeLists.txt file now accommodates a broader range of CMake versions from 3.15 to 3.30, improving compatibility without functional changes. In the Jenkinsfile, adjustments were made to the job matrix to support newer operating systems and compilers while removing a network option from the execution settings. These updates enhance build flexibility and compatibility with recent environments.

Changes

Files Change Summary
CMakeLists.txt, Jenkinsfile CMake updated to support CMake versions 3.15...3.30 and copyright year changed to 2024. Jenkinsfile modified to remove --net option and expand the builds list to include Ubuntu 24.04 and Fedora 39/40 with GCC 13/14.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9cedd33 and 072a496.

Files selected for processing (1)
  • Jenkinsfile (2 hunks)
Additional comments not posted (3)
Jenkinsfile (3)

46-46: Verify the impact of removing the --net option.

The removal of the --net option from execopts may affect network settings during the execution of the Singularity container. Ensure that this change does not impact the build process or network-dependent tasks.

90-90: Verify the availability of the Ubuntu 24.04 image with GCC 13.

Ensure that the Docker or Singularity image for Ubuntu 24.04 with GCC 13 is available and properly configured for the build process.

97-98: Verify the availability of Fedora 39 and 40 images with GCC 13 and 14.

Ensure that the Docker or Singularity images for Fedora 39 with GCC 13 and Fedora 40 with GCC 14 are available and properly configured for the build process.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dennisklein dennisklein merged commit 8fe95e6 into FairRootGroup:dev Aug 20, 2024
@dennisklein dennisklein deleted the cmake-330 branch August 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dennisklein