Skip to content

Add 'no control' controller#503

Merged
rbx merged 1 commit into
FairRootGroup:devfrom
rbx:control-none
Feb 19, 2024
Merged

Add 'no control' controller#503
rbx merged 1 commit into
FairRootGroup:devfrom
rbx:control-none

Conversation

@rbx

@rbx rbx commented Feb 19, 2024

Copy link
Copy Markdown
Member

For #443.

Here I skip also the startup sequence. The plugin changes no states at all (device remains in Idle). Was that what we wanted to solve with this?

I've tested if the device still responds to signals with this and it does.

@rbx rbx requested a review from dennisklein February 19, 2024 13:52
@coderabbitai

coderabbitai Bot commented Feb 19, 2024

Copy link
Copy Markdown
Walkthrough

Walkthrough

The update enhances the control mechanism within the FairMQ framework by refining the conditional logic for device control and introducing a new "none" control mode option. This update also includes the addition of a NoControlMode method to facilitate the "none" control mode. Additionally, minor code style improvements are made to the initialization of a test device.

Changes

Files Change Summary
fairmq/plugins/control/Control.* Adjusted control property logic, added "none" control mode with NoControlMode method.
test/device/_config.cxx Improved indentation in constructor initialization list for fDeviceThread in the TestDevice class.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Comment thread fairmq/plugins/control/Control.cxx Outdated
@rbx rbx force-pushed the control-none branch 2 times, most recently from cee031a to 46c96dc Compare February 19, 2024 15:24
@rbx rbx merged commit 39cb021 into FairRootGroup:dev Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants