Refactor shmem::Message to reduce its size in memory#485
Merged
Conversation
Member
Author
|
Want to do couple more tests before review, but let the CI run already. |
dennisklein
approved these changes
Oct 19, 2023
dennisklein
left a comment
Member
There was a problem hiding this comment.
Please put the explanation text from the PR why you flatten the MetaHeader member also into the first commit msg. Thx! Otherwise looks all fine to me.
Move the members of MetaHeader flat into shmem::Message and sort them by size to reduce the size of the class.
…ng alignment with the msg object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the size of shmem::Message from 92 bytes to 80 bytes. Two more members not clearly visible when skimming through the class are the this pointer, since we use virtual methods, and the member of the parent class -
fTransport.