Fluids: Creating Your First Fluid#539
Merged
cassiancc merged 84 commits intoFabricMC:mainfrom Mar 26, 2026
Merged
Conversation
Added functionality for AcidFluid interactions with entities and blocks.
Updated the title and description for clarity and corrected formatting.
Added information about creating a legacy block for acid fluid.
Added a new block type 'ACID' as a LiquidBlock using ModFluids.ACID_STILL.
Inject a method to cancel vanilla water screen effect when in custom fluid.
Kilip1000
suggested changes
Mar 25, 2026
Contributor
Kilip1000
left a comment
There was a problem hiding this comment.
This points out a few of the smaller, so far unadressed complaints I have.
its-miroma
requested changes
Mar 25, 2026
Member
its-miroma
left a comment
There was a problem hiding this comment.
babe, wake up, @its-miroma has requested changes again!
reference/latest/src/main/java/com/example/docs/block/ModBlocks.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/fluid/custom/AcidFluid.java
Outdated
Show resolved
Hide resolved
| // :::bucket | ||
| // :::abstractFluid | ||
| @Override | ||
| public void animateTick(Level world, BlockPos pos, FluidState state, RandomSource random) { |
Member
There was a problem hiding this comment.
This animation, if I'm reading it correctly:
- if the fluid is not a source block, nor is it FALLING (?), then play a sound 1/64th of the time
- if it is a source or it's FALLING, add a particle 1/10 of the time.
should be explained in the docs, or the animation should be simplified.
also, I don't know what I'm looking at with the magic values, and at this point I'm too afraid to ask
Co-authored-by: Miroma <its.miroma@proton.me>
Co-Authored-By: Miroma <its.miroma@proton.me>
modmuss50
previously requested changes
Mar 25, 2026
Member
modmuss50
left a comment
There was a problem hiding this comment.
Please remove the fog stuff from this PR for now, we should come up with a proper solution instead of recommending weird and wonderful workarounds.
reference/latest/src/main/java/com/example/docs/mixin/FogTypeInvoker.java
Outdated
Show resolved
Hide resolved
reference/latest/src/client/java/com/example/docs/mixin/client/CameraMixin.java
Outdated
Show resolved
Hide resolved
its-miroma
requested changes
Mar 26, 2026
Member
its-miroma
left a comment
There was a problem hiding this comment.
i removed some more fog references that were missed. the two stub classes we can keep, as a reminder, and I'll create an issue
reference/latest/src/main/java/com/example/docs/block/ModBlocks.java
Outdated
Show resolved
Hide resolved
reference/latest/src/client/resources/example-mod.client.mixins.json
Outdated
Show resolved
Hide resolved
Open
Fog changes have been removed as requested.
cassiancc
approved these changes
Mar 26, 2026
its-miroma
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request in my life, but I did want to update the fluid creation tutorial from the old FabricMC wiki.
Preview URL: https://deploy-preview-539--nimble-elf-d9d491.netlify.app/develop/fluids/first-fluid