docs: clarify eviction-max-pod-grace-period behavior with negative values#1
Merged
FabianIMV merged 2 commits intoFabianIMV:masterfrom Nov 25, 2024
Merged
docs: clarify eviction-max-pod-grace-period behavior with negative values#1FabianIMV merged 2 commits intoFabianIMV:masterfrom
FabianIMV merged 2 commits intoFabianIMV:masterfrom
Conversation
Previously, ValidateNodeSelector did not check that labels are valid. Now it does for resource.k8s.io, regardless whether an object already was created with invalid labels in an earlier Kubernetes release. Theoretically this is a breaking change and could cause problems during an upgrade, but that is highly unlikely in practice. In contrast to node affinity, DRA does not ignore parse errors (= uses NewNodeSelector, not NewLazyErrorNodeSelector), so invalid labels would have been found instead of being silently ignored. Even if some object has invalid labels, this only affects an alpha -> beta upgrade which isn't guaranteed to work seamlessly.
DRA API: validate node selector labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it
This PR updates the documentation for the
eviction-max-pod-grace-periodparameter to accurately reflect its current behavior. The existing documentation suggested that negative values would defer to the pod's specified grace period, but in practice, this is not the case.Changes made
Special notes for reviewers
The change is focused on aligning documentation with actual implementation behavior, as discussed in the original issue.
Fixes kubernetes#118172