Skip to content

First iteration to have code compile on both Jdk8 and 9#618

Closed
afester wants to merge 2 commits into
FXMisc:masterfrom
afester:jdk89MultiRelease
Closed

First iteration to have code compile on both Jdk8 and 9#618
afester wants to merge 2 commits into
FXMisc:masterfrom
afester:jdk89MultiRelease

Conversation

@afester

@afester afester commented Oct 16, 2017

Copy link
Copy Markdown
Collaborator

This is work in progress.
Opened for further discussion
Do not merge.

This approach runs through the Java8 and Java9 compiler using the grade build. It uses two separate hierarchies for Java8 and Java9 specific files. The gradle build automatically detects the used JDK and selects the appropriate source folder.

Pending:

  • Integration tests fail with Java9
    • Need to replace testfx-internal-java8 with testfx-internal-java9 - after doing this manually, only 11 tests still fail (108 Runs/10 Skipped/11 Failures)
  • Demos not yet tested
  • Source files are duplicated between Java8 and Java9. Need to pull out the common code.
  • Eclipse integration ("gradle eclipse") does not seem to select the additional source folder yet

Later, this approach could be extended to support the Java9 multi release jar approach for packaging by moving the created class files into the appropriate folders below META-INF.

@JordanMartinez

Copy link
Copy Markdown
Contributor

This relates to #270 (adding this comment so it shows up there, too).

@afester

afester commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator Author

Already done with #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants