Skip to content

zebra: fix bfd deregister message memleak#5662

Merged
mjstapp merged 1 commit intoFRRouting:masterfrom
qlyoung:fix-ptm-bfd-deregister-memleak
Jan 10, 2020
Merged

zebra: fix bfd deregister message memleak#5662
mjstapp merged 1 commit intoFRRouting:masterfrom
qlyoung:fix-ptm-bfd-deregister-memleak

Conversation

@qlyoung
Copy link
Copy Markdown
Member

@qlyoung qlyoung commented Jan 9, 2020

Removing double frees accidentally introduced a memleak

Fixes: #5658

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

@qlyoung
zebra: fix bfd deregister message memleak
4fa2974 
Removing double frees accidentally introduced a memleak

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@qlyoung qlyoung mentioned this pull request Jan 9, 2020
Closed
@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Jan 10, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5662 4fa2974
Date 01/09/2020
Start 18:55:21
Finish 19:21:08
Run-Time 25:47
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-09-18:55:21.txt
Log autoscript-2020-01-09-18:56:16.log.bz2
Memory 435 418 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Jan 10, 2020

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10364/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10364/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
Successful on other platforms
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • Ubuntu 16.04 deb pkg check
  • Topology tests on Ubuntu 18.04 amd64
  • IPv6 protocols on Ubuntu 14.04
  • Ubuntu 12.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 10 deb pkg check
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10364/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200109-01-g4fa2974c4-0 (missing) -> 7.3-dev-20200109-01-g4fa2974c4-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200109-01-g4fa2974c4-0 (missing) -> 7.3-dev-20200109-01-g4fa2974c4-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200109-01-g4fa2974c4-0 (missing) -> 7.3-dev-20200109-01-g4fa2974c4-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200109-01-g4fa2974c4-0 (missing) -> 7.3-dev-20200109-01-g4fa2974c4-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200109-01-g4fa2974c4-0 (missing) -> 7.3-dev-20200109-01-g4fa2974c4-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

mjstapp
mjstapp approved these changes Jan 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge when CI finishes...

@qlyoung
Copy link
Copy Markdown
Member Author

qlyoung commented Jan 10, 2020

@mjstapp well it's done but it failed on a centos packaging check...sigh

ci:rerun

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Jan 10, 2020

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10372/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10372/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
Successful on other platforms
  • IPv4 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 16.04 amd64
  • Ubuntu 14.04 deb pkg check
  • IPv4 ldp protocol on Ubuntu 16.04
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • Topology tests on Ubuntu 18.04 amd64
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Topotest tests on Ubuntu 16.04 i386
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
<TITLE>clang_check</TITLE>

clang_check

@qlyoung
Copy link
Copy Markdown
Member Author

qlyoung commented Jan 10, 2020

@mjstapp should be mergable

@mjstapp
Copy link
Copy Markdown
Contributor

mjstapp commented Jan 10, 2020

I'm going to go ahead and merge this without waiting for the centos packaging issue to be resolved

@mjstapp mjstapp merged commit b4ae4a1 into FRRouting:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjstapp mjstapp mjstapp approved these changes

Assignees

No one assigned

Labels

zebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zebra: Memory leaks found by LeakSanitizer

5 participants

@qlyoung @LabN-CI @NetDEF-CI @mjstapp @polychaeta