Skip to content

bgpd: fix some coverity scan issues#1554

Merged
donaldsharp merged 2 commits intoFRRouting:masterfrom
opensourcerouting:cover-fix1
Dec 14, 2017
Merged

bgpd: fix some coverity scan issues#1554
donaldsharp merged 2 commits intoFRRouting:masterfrom
opensourcerouting:cover-fix1

Conversation

@rzalamena
Copy link
Copy Markdown
Member

@rzalamena rzalamena commented Dec 14, 2017

This PR fix 2 issues pointed out by the coverity scan:

  • prefix_rd2str() slip up: use size of buffer instead of hardcoded value
  • Check for argv_find_and_parse_afi() return value before proceeding

@rzalamena
bgpd: use buffer size instead of hardcoded value
a90b8cb 
This is a possible buffer overflow.

We should always use the buffer size (whenever possible) to tell
functions what the size of the buffer is, instead of a hardcoded value.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@rzalamena
bgpd: handle argv_find_and_parse_afi return value
1ad057a 
Handle the return value of argv_find_and_parse_afi() to avoid passing
along bad values.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@donaldsharp
Copy link
Copy Markdown
Member

donaldsharp commented Dec 14, 2017

Once CI finishes I will push in.

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Dec 14, 2017

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2179/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu1404 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu1404 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2179/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

Debian8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2179/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
N: 5 tags overridden (5 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 1554, comparing to Git base SHA b9bd264
  • Base image data for Git b9bd264 does not exist - compare skipped

23 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2179/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Dec 14, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1554 1ad057a
Date 12/14/2017
Start 11:56:29
Finish 12:19:36
Run-Time 23:07
Total 1805
Pass 1805
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-12-14-11:56:29.txt
Log autoscript-2017-12-14-11:57:07.log.bz2

For details, please contact louberger

@donaldsharp donaldsharp merged commit fe15e7a into FRRouting:master Dec 14, 2017
@rzalamena rzalamena deleted the cover-fix1 branch April 8, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rzalamena @donaldsharp @NetDEF-CI @LabN-CI