Working/2.0/patch set 161218a#15
Conversation
- "redist foo" parsing modified to check for foo==vnc and foo==vnc-direct instead of just leading 'v' character - string designating ZEBRA_ROUTE_VNC_DIRECT changed from "vpn" to "vnc-direct" - route_types.pl parser recognizes 7th field to restrict availability of a route type in the redist command to specific daemons - restrict "vnc-direct" to bgpd only (doesn't make sense elsewhere) - vnc documentation updated to match
expose bgp_rfapi_get_group_by_lni_label for use by rfp
add EVPN Ethernet Tag (VID) RT
ensure as is init'ed
fix spelling of information
donaldsharp
left a comment
There was a problem hiding this comment.
shouldn't the first hunk be:
&& (mpath_cfg && CHECK_FLAG(....)
Why would we want to compare cluster length if they have not configured it from the cli?
| "Address family\n" | ||
| "Address Family modifier\n" | ||
| "Address Family modifier\n" | ||
| "Address family\n" |
There was a problem hiding this comment.
White space changes, need to be removed.
There was a problem hiding this comment.
@donaldsharp WRT && (mpath_cfg && CHECK_FLAG(....) - no as this is a passed parameter which may be NULL, i.e. not provide any config info.
| BGP_STR | ||
| "Address family\n" | ||
| "Address Family modifier\n" | ||
| "Address family\n" |
There was a problem hiding this comment.
white space changes need to be removed
|
@louberger can you add Signed-off-bys on these? |
|
@eqvinox I'll add signoffs, but not sure what you mean on the commits as they show fine for me in git log... |
This patch set includes changes resulting from initial regression runs with stable/2.0
Issues found include:
valgrind reported memory loss (this set doesn't fix them all)
missing vpn&encap commands (see #14)
some RFAPI?VNC patches were missing
- fix for issue reported in #9 (mislabeled as #30)
- Other changes made in November