Skip to content

zebra: Send nht resolved entry up to concerned protocols in all cases#12708

Merged
mjstapp merged 1 commit intoFRRouting:masterfrom
donaldsharp:no_notification
Jan 31, 2023
Merged

zebra: Send nht resolved entry up to concerned protocols in all cases#12708
mjstapp merged 1 commit intoFRRouting:masterfrom
donaldsharp:no_notification

Conversation

@donaldsharp
Copy link
Copy Markdown
Member

@donaldsharp donaldsharp commented Jan 30, 2023

There existed the idea, from Volta, that a nexthop group would not have the same nexthops installed -vs- what FRR actually sent down. The dplane would notify you.

With the addition of 06525c4 the code was put behind a bit of a wall controlled the usage of it.

The flag ROUTE_ENTRY_USE_FIB_NHG flag was being used to control which set was being sent up to concerned parties in nexthop tracking. Put this flag behind the wall and do not necessarily set it when we receive a data plane notification about a route being installed or not.

Fixes: #12706
Signed-off-by: Donald Sharp sharpd@nvidia.com

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Jan 30, 2023 •
edited
Loading

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/12708 645bb50 frr.github Build
Date 01/30/2023
Start 14:01:23
Finish 14:01:55
Run-Time 00:32
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2023-01-30-14:01:23.txt
Log make-2023-01-30-14:01:23.out.bz2
Memory

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Jan 30, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 2436 | static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 2492 | static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 2544 | static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function 'rib_process_dplane_notify':
zebra/zebra_rib.c:2436:13: error: invalid storage class for function 'process_subq_evpn'
 2436 | static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function 'process_subq_nhg'
 2492 | static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function 'process_subq_early_label'
 2544 | static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function 'process_subq_route'
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/RH9BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 2436 | static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 2492 | static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 2544 | static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9456/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/REDHAT8/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:742: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c:2437:1: error: function definition is not allowed here
{
^
zebra/zebra_rib.c:2493:1: error: function definition is not allowed here
{
^
zebra/zebra_rib.c:2545:1: error: function definition is not allowed here
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9456/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.9456/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function 'rib_process_dplane_notify':
zebra/zebra_rib.c:2436:13: error: invalid storage class for function 'process_subq_evpn'
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function 'process_subq_nhg'
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function 'process_subq_early_label'
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function 'process_subq_route'
Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/F29BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9456/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/zebra.rst:755: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 2436 | static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 2492 | static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 2544 | static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U22AMD64BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9456/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 2436 | static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 2492 | static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 2544 | static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9456/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9456/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.9456/frr-source'
zebra/zebra_rib.c: In function rib_process_dplane_notify:
zebra/zebra_rib.c:2436:13: error: invalid storage class for function process_subq_evpn
 static void process_subq_evpn(struct listnode *lnode)
zebra/zebra_rib.c:2492:13: error: invalid storage class for function process_subq_nhg
 static void process_subq_nhg(struct listnode *lnode)
zebra/zebra_rib.c:2544:13: error: invalid storage class for function process_subq_early_label
 static void process_subq_early_label(struct listnode *lnode)
zebra/zebra_rib.c:2571:13: error: invalid storage class for function process_subq_route

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9456/artifact/CI101BUILD/config.status/config.status

@donaldsharp
zebra: Send nht resolved entry up to concerned protocols in all cases
8ce0e51 
There existed the idea, from Volta, that a nexthop group would not have
the same nexthops installed -vs- what FRR actually sent down.  The
dplane would notify you.

With the addition of 06525c4
the code was put behind a bit of a wall controlled the usage
of it.

The flag ROUTE_ENTRY_USE_FIB_NHG flag was being used
to control which set was being sent up to concerned parties
in nexthop tracking.  Put this flag behind the wall and
do not necessarily set it when we receive a data plane
notification about a route being installed or not.

Fixes: FRRouting#12706
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@github-actions github-actions bot added size/XS and removed size/S labels Jan 31, 2023
@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Jan 31, 2023

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9468/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@mjstapp mjstapp merged commit 62f9428 into FRRouting:master Jan 31, 2023
@donaldsharp donaldsharp deleted the no_notification branch July 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjstapp mjstapp mjstapp approved these changes

Assignees

No one assigned

Labels

bugfix master size/XS zebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BGP neighbor stuck in Active state (TCP_connection_open_failed)

4 participants

@donaldsharp @LabN-CI @NetDEF-CI @mjstapp