Merged
Conversation
- fillform.com no longer exists - httpbingo.org changed some responses - Several tests needed error handling so they fail instead of timing out. - Some error handling updates were needed for modern node versions. - Longer timeouts were needed for test suite reliability with remote hosts.
request 2.88.1 used tough-cookie 2.5.0 as a dependency In that version of tough-cookie, the `getCookies()` method was not a sync method. Either you had to call a callback or use `getCookiesSync()`. postman-request also uses a tough-cookie-compatible fork. Ref: https://github.com/request/request/blob/3c0cddc7c8eb60b470e9519da85896ed7ee0081e/package.json#L47 Ref: https://www.npmjs.com/package/tough-cookie/v/2.5.0
postman-request is a fork of request 2.88.1, with only some security and bug fixes applied. All tested passed as-is with exception one that appeared it needed to be updated to be compatible with the last released version of `request` as well.
This commit changes the dep security fixes that can be fixed by by `npm audit fix`
More aggresively upgrades vulnerable deps. These are all "devDeps", and all tests pass after the update.
It was no longer actively being used.
`coveralls` depended on deprecated `request` module which in turn depended on vulnerable `request` module.
Owner
|
Great work, will merge it and release it as a new major version ! |
Owner
|
Thanks a lot, released in v8.0, https://github.com/FGRibreau/node-request-retry/releases/tag/v8.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the PRs from earlier today, addressing all the vulnerable dependency issues for this module reported by
npm audit, confirming all tests pass after the change.To facilitate this, some
dev Dependenciesthat have vulns are not necessary were removed from the project, includingupdtr-- not used in ~5 years-- andcoverallswhich ironically stilluses the deprecated
requestmodule.