Secure, compatible replacement of request with supported postman-request fork#152
Merged
FGRibreau merged 3 commits intoFGRibreau:masterfrom Oct 28, 2025
Merged
Conversation
- fillform.com no longer exists - httpbingo.org changed some responses - Several tests needed error handling so they fail instead of timing out. - Some error handling updates were needed for modern node versions. - Longer timeouts were needed for test suite reliability with remote hosts.
request 2.88.1 used tough-cookie 2.5.0 as a dependency In that version of tough-cookie, the `getCookies()` method was not a sync method. Either you had to call a callback or use `getCookiesSync()`. postman-request also uses a tough-cookie-compatible fork. Ref: https://github.com/request/request/blob/3c0cddc7c8eb60b470e9519da85896ed7ee0081e/package.json#L47 Ref: https://www.npmjs.com/package/tough-cookie/v/2.5.0
postman-request is a fork of request 2.88.1, with only some security and bug fixes applied. All tested passed as-is with exception one that appeared it needed to be updated to be compatible with the last released version of `request` as well.
Contributor
Author
|
Although this was a 1:1 replacement, I think the better refactor is to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It includes the test fixes from earlier PR that fixed the tests, as I needed to make sure tests pass. That earlier PR is expected to be reviewed first.