Fix acceptance test for new index ping POST#840
Merged
dennisvang merged 3 commits intosupport/1.18.xfrom Jan 29, 2026
Merged
Conversation
so we can clearly see if settings come from db or defaults
This is actually a quick and dirty fix, following the same pattern as the other tests. However, the underlying problem remains: if you rely on cleaning up the db before each test, as opposed to after each test, then you need to make sure *everything* is cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually a quick and dirty fix, following the same pattern as the other tests, cleaning up the index settings repository at the start of the test.
However, the underlying problem remains:
Individual repositories are cleaned up before each test. This way it is all too easy to forget cleaning up a repository.
If you rely on cleaning up the db before each test, as opposed to after each test, then you need to make sure everything (i.e. the whole db) is cleaned up.
fixes #839