Skip to content

Feat catnip support#49

Merged
birme merged 10 commits intoEyevinn:mainfrom
axeldahlberg:feat-catnip-support
Apr 23, 2025
Merged

Feat catnip support#49
birme merged 10 commits intoEyevinn:mainfrom
axeldahlberg:feat-catnip-support

Conversation

@axeldahlberg
Copy link
Copy Markdown
Contributor

@axeldahlberg axeldahlberg commented Apr 23, 2025

This pull request solves issue: Full catnip support #48

#48 (comment)

Adds support for:

  • IPv4 address
  • IPv4 network
  • IPv6 address
  • IPv6 Prefix
  • Autonomous
  • Validation of catnip claims

I encourage to review function names and some Typescript specific changes (like type definitions).

birme
birme approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

@birme
Copy link
Copy Markdown
Contributor

birme commented Apr 23, 2025

To fix linting and prettier issues just type:

% npx prettier --write --ignore-unknown .

and then push the changes

@birme
Copy link
Copy Markdown
Contributor

birme commented Apr 23, 2025

Sorry, I missed these ones

/home/runner/work/node-cat/node-cat/src/catnip.ts
Error:    65:14  error    'catnipObject' is never reassigned. Use 'const' instead      prefer-const
Error:   107:14  error    'catnipString' is never reassigned. Use 'const' instead      prefer-const

that should be fixed. You can check with npm run lint that no linting errors remains

@birme birme merged commit 7ad8183 into Eyevinn:main Apr 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birme birme birme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axeldahlberg @birme