Settings rewrite for easier data validation and resseting to defaults #93
Merged
RedHawk989 merged 8 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom Oct 12, 2023
Conversation
… defaults and for better settings handling
5fd1ff3 to
5a84217
Compare
…ch' into feature/config-rewrite-with-defualts-reset # Conflicts: # EyeTrackApp/algo_settings_widget.py # EyeTrackApp/general_settings_widget.py # EyeTrackApp/osc.py
RedHawk989
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to do three things:
update the version of pydantic to 2.4 and fixup stuff as 2.4 fixes a lot of issues v1 had
refactor the config into a more modular and easier to extend structure
add the ability to reset the config to defaults per panel
algo settings rewrite
resetting to defaults
refactor config validation
Checklist