Fixes calibration values#86
Merged
RedHawk989 merged 1 commit intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom Jun 19, 2023
Merged
Fixes calibration values#86RedHawk989 merged 1 commit intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom
RedHawk989 merged 1 commit intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom
Conversation
There was a bug that made calibration values all default to 1 if there was a failure of the try/except, fixed the code so it does error checking before running
Contributor
Author
|
Spent the night testing this fix and I'm very happy with it. |
RedHawk989
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug that made calibration values all default to 1 if there was a failure of the try/except, fixed the code so it does error checking before running
Related issue (if applicable): fixes #
Checklist
The pull request is done against the latest development branch
Only relevant files were touched
Code change compiles without warnings
The code change is tested and works with EyeTrackVR core ESP32 newest release
I accept the CLA.